Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stubgenc] Generate Inline generics from __type_params__ #17559

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

[stubgenc] Generate Inline generics from __type_params__ #17559

wants to merge 26 commits into from

Conversation

InvincibleRMC
Copy link
Contributor

@InvincibleRMC InvincibleRMC commented Jul 22, 2024 •
edited
Loading

Fixes #17447

This allows generating inline generics for stubgenc by using __type_params__.

Similar to #17463 but for __type_params__ instead of __annotations__

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
sobolevn
sobolevn reviewed Jul 23, 2024
View reviewed changes
mypy/test/teststubgen.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@InvincibleRMC
Copy link
Contributor Author

@sobolevn any other comments / concerns?

@InvincibleRMC
Copy link
Contributor Author

@sobolevn Friendly ping if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

Assignees
No one assigned
Labels
topic-stubgen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stubgen] infer_sig_from_docstring fails with python3.12 inline generic
3 participants
@InvincibleRMC @sobolevn @AlexWaygood